-
Notifications
You must be signed in to change notification settings - Fork 242
Create DetectFloatingPointNumbers.py #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Missing problem added with working solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution is listed in RegexandParsing/IntroductiontoRegexModule.py
As your solution is updated, I suggest to do the following:
- Accommodate the code review comment.
- Delete that file
RegexandParsing/IntroductiontoRegexModule.py. - Update the
readme.mdto listRegexandParsing/DetectFloatingPointNumbers.py
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This regex pattern can be changed to compile('^[-+]?\d*\.\d+$')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly. Done.
Regex Pattern updated as mentioned in review.
- Regex Pattern improvised.
- Previous obsolete file deleted
- Readme updated with DetectFloatingPointNumbers.py in place of IntroToRegex.py
Please review and merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facilitated the change request smoothly. Thank you.
Missing problem added with working solution.