-
Notifications
You must be signed in to change notification settings - Fork 64
Remove import star #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove import star #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@roaffix
roaffix
force-pushed
the
feature/remove-import-star
branch
from
November 13, 2020 01:16
a0aa3fe to
6fb2dfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core features in this PR:
defaults(explained below)from ... import *About module changes:
arraymodule was used inlibraryand vice-versa. It led to conflict, so I moved some functions fromlibraryto another moduledefaults. The same withutilanddevice, so 2 functions were moved from the first one to the second one.Comment:
If this PR will be merged, I think it'd be better to update the minor version of the package. Also, docs update needed.