Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix #744, Setting month and year before setting date solves the issue#745

Open
technoknol wants to merge 1 commit into
arqex:master from
technoknol:master
Open

Fix #744, Setting month and year before setting date solves the issue #745
technoknol wants to merge 1 commit into
arqex:master from
technoknol:master

Conversation

@technoknol

@technoknol technoknol commented Oct 13, 2020

Copy link
Copy Markdown

Description

  1. Setting month and year before setting date solves the issue
  2. Included test case for Date issue for month having 31 days #744 .

Motivation and Context

Checklist

[x] I have not included any built dist files (us maintainers do that prior to a new release)
[x] I have added tests covering my changes
[x] All new and existing tests pass
[ ] My changes required the documentation to be updated
 [ ] I have updated the documentation accordingly
 [ ] I have updated the TypeScript 1.8 type definitions accordingly
 [ ] I have updated the TypeScript 2.0+ type definitions accordingly

Copy link
Copy Markdown
Author

Test fails because of dist files are older ones. I've tested it with new build and it works.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /