-
Notifications
You must be signed in to change notification settings - Fork 377
Shadow added to SpaceNavigationView, behaviour tested with/without be...#89
Shadow added to SpaceNavigationView, behaviour tested with/without be... #89mecoFarid wants to merge 1 commit into
Conversation
vishalroygeek
commented
Feb 20, 2019
@mecoFarid can you explain it how to do properly ? What are the params ? And if @armcha doesn't accepts it, how can I use yours ? Since I didn't found any implementation methods on your fork.
Download the lib from here and unzip it. Then follow this StackOverflow question to add it as an external library. In this question, use Approach 2) part. While following steps in this question choose Import Module instead of New Module on step 1 and choose Android Library instead of Import JAR/.AAR Package on step 2. Then browse the unzipped folder you've just downloaded. The next steps are the same with ones stated in the question. That's it. Now just use SpaceNavigationView in your .xml, shadow will be applied by default you don't have to define additional parameters for a shadow to be visible.
vishalroygeek
commented
Feb 20, 2019
@mecoFarid thanks for your reply. I know how to download the zip and use the library. I was just looking for simple implementation methods. Anyways, if the shadow occurs by default, what is its value in dp ? Can you share an image to get an idea of elevation effect. Also, it would be great if there is a method to provide own value for elevation. Doesn't matters, if it would be from XML or directly from JAVA code.
mecoFarid
commented
Feb 21, 2019
@vishalroygeek default Material elevation for AppBar. Since there is no parameter for shadow length in AppBar either. I will provide two options hasShadow=true/false but length will not be dynamic as per Material design requirements. Yet, I will add one more option to make it look like BottomNavigation. I mean single line along the border; parameter will be 'hasBorder=true/false'. I'm not thinking of implementing those in a couple of days, but will do it in the near future for people who're still interested.
vishalroygeek
commented
Feb 22, 2019
@mecoFarid that's cool to add those params. But i would request you to add dynamic elevation param as well. Because sometimes some UI elements need to stand out more than it should. So, providing dynamic elevation would be great. You can also see that most of the UI elements have the elevation param. And it really helps in many cases. Anyways, you did a great job buddy. And let me know when you make the suitable changes
critsxy
commented
Apr 15, 2019
Download the lib from here and unzip it. Then follow this StackOverflow question to add it as an external library. In this question, use Approach 2) part. While following steps in this question choose
Import Moduleinstead ofNew Moduleon step 1 and chooseAndroid Libraryinstead ofImport JAR/.AAR Packageon step 2. Then browse the unzipped folder you've just downloaded. The next steps are the same with ones stated in the question. That's it. Now just useSpaceNavigationViewin your.xml, shadow will be applied by default you don't have to define additional parameters for a shadow to be visible.
This link was deleted.
The link has expired on 02/27/2019
:( :(
SWRHARD
commented
May 8, 2019
the link was deleted, can u upload this library again, please?
mecoFarid
commented
May 8, 2019
Here is the link spacelib. Also, edited link in the original comment.
Added shadow to SpaceNavigationView. Shadow consists of offset paths with different levels of alphas along the upper border of SaceNavigationView