-
Notifications
You must be signed in to change notification settings - Fork 456
Make configuring for cloud9 IDE easier#63
Make configuring for cloud9 IDE easier #63etherealite wants to merge 1 commit intoarkency:master from etherealite:cloud9
Conversation
andrzejkrzywda
commented
Jun 27, 2016
@etherealite thanks for the PR, it would be great to make it easier to run koans on Cloud9!
We'll just double-check if it works both on Cloud9 and locally and if so, it'll be merged.
After I tweaked it to run locally, it works.
I think the local version should be default, so maybe we need to apply this back:
-var host = 'react-koans-etherealite.c9users.io';
-var webpackPort = 8081;
+var host = 'localhost';
+var webpackPort = 9090;
and then add a README section explaining how to make it work on cloud9, then it would be best?
What's your opinion @etherealite? Can you help with this?
etherealite
commented
Jun 28, 2016
@andrzejkrzywda I'm glad for the opportunity to give back a little.
I completely agree that this branch should be changed so that webpack will bind to localhost:9090 by default.
I have only one difference of opinion on your proposal. I do not think cloud 9 installation instructions should have their own section in the README.md, as the subject is incidental to the existing directions. How about putting a link in the README.md? It could read something like: 'how to install in cloud9' and then point to a GitHub wiki page that had the directions.
andrzejkrzywda
commented
Jun 28, 2016
Good point with README vs GitHub wiki. Let's go for this.
etherealite
commented
Jun 28, 2016
Are the ES6 template literals ok to use, or should I make it ES5 compatible?
voter101
commented
Jun 28, 2016
Stuff from ES6 is fine, so template literals are OK to use.
Getting this awesome project working in Cloud9 IDE can be a little tedious. Finding all the configuration strings and changing the port numbers to be compatible with Cloud9 is a bit on the arduous side.
This PR allows one to set the port for the webpack dev server by defining a single variable at the top of the server.js file.