-
-
Notifications
You must be signed in to change notification settings - Fork 6
Notify running LS about build complete. #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ref: arduino/arduino-ide#714 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
404d8dd to
3dbfd72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you prefer the console.error over the showError function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question; the original code does not show the error if the LS failed to start. I did not want to change this behavior, but I could do it.
Note, if we use vscode.window.showErrorMessage here, it will be a notification message in IDE2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only effective change here is that I use console.error instead of console.log with an additional Failed to start the language server. message.
New:
arduino.languageserver.notifyBuildDidCompletecommand that can be called from the IDE2 to set the new build path of the libraries after a verify,ino/didCompleteBuildprotocol extension. (See Some tweaks on how sketch is rebuild during editing arduino-language-server#118 )Ref: arduino/arduino-ide#714
Signed-off-by: Akos Kitta a.kitta@arduino.cc