Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update SPI.adoc #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
per1234 merged 2 commits into arduino:master from John-Karatka:patch-1
Jun 27, 2022
Merged

Update SPI.adoc #889

per1234 merged 2 commits into arduino:master from John-Karatka:patch-1
Jun 27, 2022

Conversation

Copy link
Contributor

@John-Karatka John-Karatka commented Jun 24, 2022

Added endTransaction() link to function section.

per1234 reacted with thumbs up emoji
Added endTransaction() link to function section.
Copy link
Contributor Author

@John-Karatka John-Karatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed CLA

Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will be best to place the link on the line after the link for the beginTransaction reference page, as the order was in the original SPI library reference before the loss of the link during the migration.

You can see how it used to look here on the Wayback Machine snapshot:

https://web.archive.org/web/20220120162953/https://www.arduino.cc/en/Reference/SPI

image

@per1234 per1234 self-assigned this Jun 26, 2022
Moved endTransaction() to after beginTransaction() as suggested.
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this serious omission @John-Karatka!

@per1234 per1234 merged commit fee4321 into arduino:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /