Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update Keyboard documentation #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicBallinger wants to merge 1 commit into arduino:master from NicBallinger:patch-1

Conversation

Copy link

@NicBallinger NicBallinger commented Apr 24, 2022

Update Keyboard documentation to include other non-ascii keys listed in Keyboard.h

This is a minimalistic change. Breaking the table apart to better match the source may make the documentation more useful.

Adding a link to the definitions in Keyboard.h would may the page more pedagogical.

But those are just suggestions.

The source for Keyboard.h is located here.
https://github.com/arduino-libraries/Keyboard/blob/master/src/Keyboard.h

per1234 reacted with thumbs up emoji
Update Keyboard documentation to include other non-ascii keys listed in Keyboard.h 
https://github.com/arduino-libraries/Keyboard/blob/master/src/Keyboard.h 
Copy link

CLAassistant commented Apr 24, 2022
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Author

Ah, It appears as if the changes I'm documenting have not yet been released. I guess I should close this for now?

Copy link
Collaborator

per1234 commented May 8, 2022

Thanks @NicBallinger. The changes you proposed here have now been made via #881. I really appreciate your care for keeping this important documentation up to date.

For future reference, there is no problem with submitting a pull request here for changes related to unreleased code. You are correct that we should not merge the pull requests until the release happens, but getting prepared for the release in advance is always a good thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /