-
-
Notifications
You must be signed in to change notification settings - Fork 727
Update define.adoc #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update define.adoc #732
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the extra -
that is breaking the links to the pages under the "Variable Scope & Qualifiers" section, I have verified that this worked correctly up until recently, as you can see from the Wayback Machine's archive of the page:
http://web.archive.org/web/20190916201140/https://www.arduino.cc/reference/en/language/variables/variable-scope--qualifiers/const/
I've notified Arduino's developers of this change, so I'll wait to see whether the dash needs to be removed from the URLs before taking any action on this issue.
Hi @per1234 : Thanks for taking this up. Okay, I was unaware of this. I got the inconsistent link working after removing the extra -
and hence made a PR.
I've notified Arduino's developers of this change, so I'll wait to see whether the dash needs to be removed from the URLs before taking any action on this issue.
Sure, Thanks.
Hi @omshinde. The issue with the links breaking when the current page's URL is missing the trailing slash has now been fixed.
However, the issue with the changed URL for the Variable Scope & Qualifiers section has still not been fixed and I think it's probably best for us to go ahead and update those URLs. So if you would like to update your pull request to only remove the extra hyphen from the const
link in the "Description` section, I'd be happy to merge this.
Thanks!
Thanks so much @omshinde!
Thanks @per1234! I only removed the extra -
from the const
link in the description
section. Though there is extra -
present in the link redirecting from const
of See also
section too in the same page (and it is not a trailing /
issue which has been resolved already). Please verify it once as I am not able to see the updated changes.
Thanks again for your efforts, @per1234!
@per1234
I am sorry for the confusion. My previous comment stands corrected. I checked it just now and it seems perfect. Thanks for your help! I will delete this branch now. :)
Fix #731 : Update inconsistent links