-
-
Notifications
You must be signed in to change notification settings - Fork 481
Add rules to find incorrectly formatted units #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@martab1994 I've added some linter rules in this PR to issue warnings if inconsistent unit formatting is detected.
Gatsby Cloud Build Report
docs-content
🎉 Your build was successful! See the Deploy preview here.
Build Details
🕐 Build time: 3m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some ' ' to better differentiate the 'Megabit per second' compared to the rest of the sentence. Also added this to the other comments. What do you think?
I also updated the Mbps and the Gbps according to our guides.
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
@jhansson-ard Committed your suggestions. Does it now catch all the desired misspellings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this part creates an issue, I updated it here I think
What Needs To Be Reviewed
Some test content could be e.g.
How To Give Feedback
Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏