-
-
Notifications
You must be signed in to change notification settings - Fork 480
[PC-1206][PC-965][PC-1204] Application Note - Nicla Voice - Intruder Detector #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PC-1206][PC-965][PC-1204] Application Note - Nicla Voice - Intruder Detector #971
Conversation
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...ps://github.com/arduino/docs-content into mcmchris/nicla-voice/app-note-intruder-detector
...ps://github.com/arduino/docs-content into mcmchris/nicla-voice/app-note-intruder-detector
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...uder-detector/content.md Co-authored-by: Julián Caro Linares <jcarolinares@gmail.com>
...ps://github.com/arduino/docs-content into mcmchris/nicla-voice/app-note-intruder-detector
...uder-detector/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This content is ready for publiccation
@mcmchris `please do not merge
Once we have your GO @martab1994 we go live
Thank you all, amazing job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for you great work! Just please have a look at my comments to highlight we are using Machine Learning Tools powered by Edge Impulse and avoid mentioning Edge Impulse since we have this white-label version. Thanks!
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here again, the right path should be from Arduino IoT Cloud, use the Machine Learning Tools integration, basically a white label version of the full Edge Impulse platform. See here an example on how we use this machine learning tools for Nicla Voice: https://docs.arduino.cc/tutorials/nicla-voice/getting-started-ml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid we do not have a white label or more elegant version of the edge impulse cli tool and therefore we have to mention it because it is a tool necessary to perform the project (I will check if we can do it differently in the future if possible)
However, we can improve the message following the same strategy done at the Nicla Voice Getting Started:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to
- Edge Impulse® CLI ,to easily flash any Machine Learning model created with the Arduino Machine Learning Tools, we can install the Edge Impulse Cli tool following these instructions
I don't find a best solution with the actual status of the tools, should be enough imho cc @martab1994
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
content/hardware/06.nicla/boards/nicla-voice/tutorials/ei-intruder-detector/content.md
Outdated
Show resolved
Hide resolved
@mcmchris I will do these changes thank you!
@martab1994 changes done.
Once you think is ready please change your review to approved it and tell me a publication date
Thank you for the priceless feedback!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks =) I think we can merge! Thanks so much for all your effort =)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
What This PR Changes
Contribution Guidelines