Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

updated link for OPTA #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcarolinares merged 1 commit into main from akash73-patch-2
May 4, 2023
Merged

updated link for OPTA #866

jcarolinares merged 1 commit into main from akash73-patch-2
May 4, 2023

Conversation

Copy link
Member

@akash73 akash73 commented Feb 28, 2023
edited
Loading

What This PR Changes

added https://docs.arduino.cc/hardware/opta

Contribution Guidelines

Copy link

gatsby-cloud bot commented Feb 28, 2023

✅ docs-content deploy preview ready

TaddyHC
TaddyHC previously approved these changes Feb 28, 2023
Copy link
Contributor

@TaddyHC TaddyHC left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extension, lgtm! @jcarolinares , I think it would be nice if you could take a quick look at it too. It's regarding the added link to Opta documentation page instead of the store link (Which we haven't included since it could be shared with Finder) for the updated Arduino & Modbus article. I think it should be good but checking in just in case.

Copy link
Contributor

@jcarolinares jcarolinares left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a nice solution for the store link problem, but, we have to wait, the link won't work and if possible I would move Opta to a new hardware block

@jcarolinares jcarolinares dismissed stale reviews from TaddyHC and themself March 2, 2023 07:42

Blocked until we confirm the right link

Copy link
Member Author

akash73 commented Mar 2, 2023

@TaddyHC @jcarolinares not sure I've understood why is blocked. in the page there's no mention to any store link.
every product listed before the OPTA has a link do docs, not to the store.

@jhansson-ard jhansson-ard added arduino Bugs and fixes added by the Arduino Team pro fix/update A small fix or update labels Apr 20, 2023
Copy link
Member Author

akash73 commented May 4, 2023

up

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocked

Looks good to me

Merging

@jcarolinares jcarolinares merged commit eab19fe into main May 4, 2023
@jcarolinares jcarolinares deleted the akash73-patch-2 branch May 4, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarolinares jcarolinares jcarolinares approved these changes

@TaddyHC TaddyHC TaddyHC left review comments

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /