Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove superfluous url_guide properties #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebromero wants to merge 1 commit into main from sebromero/url-guide-removal

Conversation

Copy link
Contributor

@sebromero sebromero commented Dec 7, 2022

What This PR Changes

  • This PR removes all the superfluous url_guide properties in the product files. These articles are used in the setup guide but are inferred by the specified core.

Contribution Guidelines

Copy link

gatsby-cloud bot commented Dec 7, 2022
edited
Loading

✅ docs-content deploy preview ready

Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. This mechanism was mainly in place before the interactive guide was there.

Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: looks like there are several conflicts due to another PR that was merged earlier today (#726)

Copy link
Contributor

@sebromero any way we can fix the issues and merge this? 🙏🏼

@jhansson-ard jhansson-ard added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team infrastructure Fixes and updates to the infrastructure of the repo labels Apr 20, 2023
Copy link
Contributor Author

@jhansson-ard @karlsoderby Please check and merge

Copy link
Contributor

This PR is not relevant anymore because of the changes to Docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby Awaiting requested review from karlsoderby

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update infrastructure Fixes and updates to the infrastructure of the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /