-
-
Notifications
You must be signed in to change notification settings - Fork 478
Remove outdated info re: Serial Monitor send trigger in IDE 2.x #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous versions of Arduino IDE 2.x, the keyboard shortcut used to trigger the sending of a message from Serial Monitor to the board was Ctrl+Enter. Since this was different from the shortcut used by Arduino IDE 1.x, and user reports indicated this was a significant source of confusion, a note was added to the Arduino IDE 2.x Serial Monitor tutorial about the change. The keyboard shortcut was changed to Enter in the Arduino IDE 2.0.1 release, making the tutorial's information about the changed shortcut obsolete. For this reason, it is hereby removed. The removed section also documented an additional change to Serial Monitor: the loss of the "Send" button, which is still the case. The primary purpose for adding the section was to document the keyboard shortcut change and my impression is that there is no need to mention the removal of the button now that there is an intuitive keyboard shortcut for sending the message.
@per1234
per1234
added
fix/update
A small fix or update
arduino
Bugs and fixes added by the Arduino Team
labels
Nov 30, 2022
karlsoderby
karlsoderby
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes let's remove this section. Thank you @per1234 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
In previous versions of Arduino IDE 2.x, the keyboard shortcut used to trigger the sending of a message from Serial Monitor to the board was Ctrl+Enter.
Since this was different from the shortcut used by Arduino IDE 1.x, and user reports indicated this was a significant source of confusion, a note was added to the Arduino IDE 2.x Serial Monitor tutorial about the change (#287).
The keyboard shortcut was changed to Enter (arduino/arduino-ide#1402) in the Arduino IDE 2.0.1 release, making the tutorial's information about the changed shortcut obsolete. For this reason, I propose to remove the section from the tutorial.
The removed section also documented an additional change to Serial Monitor: the loss of the "Send" button, which is still the case (arduino/arduino-ide#348). The primary purpose for adding the section was to document the keyboard shortcut change and my impression is that there is no need to mention the removal of the button now that there is an intuitive keyboard shortcut for sending the message.
Contribution Guidelines