Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[PC-971] benjamindannegard/Added-connectivty-tutorial-for-Opta #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Copy link
Contributor

@BenjaminDannegard BenjaminDannegard commented Nov 11, 2022

What This PR Changes

  • Added connectivity tutorial to the Opta

Contribution Guidelines

Copy link

gatsby-cloud bot commented Nov 11, 2022 •
edited
Loading

✅ docs-content deploy preview ready

@BenjaminDannegard BenjaminDannegard changed the title (削除) benjamindannegard/Added-connectivty-tutorial-for-Opta (削除ここまで) (追記) [PC-971] benjamindannegard/Added-connectivty-tutorial-for-Opta (追記ここまで) Dec 20, 2022
@TaddyHC TaddyHC self-requested a review December 20, 2022 23:36
Copy link
Contributor

@TaddyHC TaddyHC left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes directly within the content. Most of them were to address typos and phrasings. Mainly Modbus TCP via Ethernet Port's section content have been corrected as it was mixing some concepts. Additionally, I found that some phrasings of the same Modbus section are from a different source, it would be great to see if it can be referenced. Please have a look at the updated content. 👍

@jcarolinares jcarolinares requested review from TaddyHC and marqdevx and removed request for jcarolinares December 21, 2022 08:14
Copy link
Contributor

@TaddyHC TaddyHC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made some changes directly within the content. Most of them were to address typos and phrasings. Mainly Modbus TCP via Ethernet Port's section content have been corrected as it was mixing some concepts. Additionally, I found that some phrasings of the same Modbus section are from a different source, it would be great to see if it can be referenced. Please have a look at the updated content. 👍

I have made direct changes previously as in the comment. But due to new naming rule for Arduino Opta®, I have made new suggestions now including in regard of trademark rule. Please have a look on these suggestions.

BenjaminDannegard and others added 15 commits December 22, 2022 14:11 
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...rials/getting-started-connectivity/content.md
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
@jcarolinares jcarolinares removed the request for review from marqdevx December 22, 2022 15:47
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes done. Looks good to me.

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional changes, just blocking PR to avoid undesired publication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaddyHC TaddyHC TaddyHC left review comments

@jcarolinares jcarolinares jcarolinares requested changes

@Fr4ng Fr4ng Awaiting requested review from Fr4ng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /