-
-
Notifications
You must be signed in to change notification settings - Fork 476
[TC-346] MKR WiFi 1010 App Note #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ docs-content deploy preview ready
- Deploy preview
- Build logs · 15m build time
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
Hey @aliphys is there anything needed to go live with this article?
Hey @aliphys is there anything needed to go live with this article?
Other people have also reported issues with MathJax and Gatsby e.g. gatsbyjs/gatsby#16983
For this task, I'll render images, and upload them instead.
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
...rdware/01.mkr/01.boards/mkr-wifi-1010/tutorials/mkr-battery-app-note/mkr-battery-app-note.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @aliphys . Left some comments that needs to be addressed before merging.
fd5e2e0 to
6212e8e
Compare
Hey @aliphys you will need to rebase this PR because of a gatsby issue we had last week. Also there are some small issues to fix with the spellcheck and content linter checks.
@karlsoderby So I should rebase it again?
@aliphys Ah I see that you did that now! I saw that gatsby fail and I assumed it was due to that issue. I re-ran the check now so hopefully it works :)
Current PR branch superseeds the previous (https://github.com/arduino/docs-content/tree/aliphys/mkrBatteryAppNote ) branch, hence it is deleted
...battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...battery-app-note/mkr-battery-app-note.md
...battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...battery-app-note/mkr-battery-app-note.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
9b42c23 to
9abbe34
Compare
@karlsoderby can we merge this app note now? :)
Gatsby building now working, re-based branch and now up to date 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, I did not review
...hield-launch-branch GIGA display shield datasheet update from launch branch
Uh oh!
There was an error while loading. Please reload this page.
What This PR Changes
Contribution Guidelines