Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Correct variable name reference in "Writing a Library for Arduino" #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jhansson-ard merged 2 commits into arduino:main from per1234:fix-variable-name
Jul 18, 2022
Merged

Correct variable name reference in "Writing a Library for Arduino" #377

jhansson-ard merged 2 commits into arduino:main from per1234:fix-variable-name
Jul 18, 2022

Conversation

Copy link
Contributor

@per1234 per1234 commented Jul 17, 2022
edited
Loading

The text description of the library's origin sketch incorrectly references a variable named ledPin. That sketch, and all following code based on it uses the variable name pin:

int pin = 13;

Fixes #376

What This PR Changes

The incorrect variable name in the description is hereby changed to match the real variable name in the code.

Contribution Guidelines

marqdevx reacted with rocket emoji
The text description of the library's origin sketch incorrectly references a variable named `ledPin`. That sketch, and all following code based on it uses the variable name `pin`.
The incorrect variable name in the description is hereby changed to match the real variable name in the code.
@per1234 per1234 added the bug Something isn't working label Jul 17, 2022
...or Arduino"
Co-authored-by: Pablo Marquínez Ferrándiz <pablomarqfer@gmail.com>
@per1234 per1234 added the arduino Bugs and fixes added by the Arduino Team label Jul 17, 2022
@jhansson-ard jhansson-ard merged commit 89a5df2 into arduino:main Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marqdevx marqdevx marqdevx left review comments

@jhansson-ard jhansson-ard jhansson-ard approved these changes

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"ledPin" in Writing a Library for Arduino

AltStyle によって変換されたページ (->オリジナル) /