Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Portenta X8 tutorial: custom image building[PC-920] #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marqdevx merged 43 commits into main from marqdevx/portenta-X8/image-building
Oct 7, 2022

Conversation

Copy link
Member

@marqdevx marqdevx commented Jul 15, 2022

What This PR Changes

  • Portenta X8 tutorial: custom image building

@marqdevx marqdevx added Tutorial arduino Bugs and fixes added by the Arduino Team pro labels Jul 15, 2022
@marqdevx marqdevx self-assigned this Jul 15, 2022
Copy link

gatsby-cloud bot commented Jul 15, 2022 •
edited
Loading

✅ docs-content deploy preview ready

@marqdevx marqdevx marked this pull request as ready for review August 5, 2022 12:11
Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Left some suggestions

 

Co-authored-by: BenjaminDannegard <benjamin.dannegard@gmail.com>
marqdevx and others added 2 commits August 8, 2022 15:29
marqdevx and others added 2 commits August 10, 2022 12:50 
Co-authored-by: Vanessa Maegima <vanessa.maegima@foundries.io>
Copy link
Contributor

@kprosise kprosise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided a handful of suggestions, feel free to question any of them.

 

Co-authored-by: Katrina Prosise <katrina.prosise@foundries.io>
Copy link
Member Author

marqdevx commented Oct 3, 2022 •
edited
Loading

Thanks for the review @kprosise it was awesome 💯

Regarding the headers, I do that cause while ago I've had some issues rendering the tutorials like you suggested, I'll check it out 👌

Copy link
Contributor

kprosise commented Oct 4, 2022

Thanks for the review @kprosise it was awesome 💯

Regarding the headers, I do that cause while ago I've had some issues rendering the tutorials like you suggested, I'll check it out 👌

Let me know, I would be happy to help debug, either now or as part of a future PR or patch.
marqdevx reacted with rocket emoji

Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marqdevx marqdevx merged commit 09cfa51 into main Oct 7, 2022
@marqdevx marqdevx deleted the marqdevx/portenta-X8/image-building branch October 7, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminDannegard BenjaminDannegard Awaiting requested review from BenjaminDannegard

3 more reviewers

@vanmaegima vanmaegima vanmaegima approved these changes

@kprosise kprosise kprosise left review comments

@caiotpereira caiotpereira caiotpereira left review comments

Reviewers whose approvals may not affect merge requirements
Labels
arduino Bugs and fixes added by the Arduino Team pro Tutorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /