Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove rogue curly brace in Nano 33 BLE Sense Rev2 IMU accelerator tutorial #2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@mzen228 mzen228 commented Aug 6, 2025
edited
Loading

What This PR Changes

  • The final code sample for the IMU accelerator tutorial for the Arduino Nano 33 BLE Sense Rev2 has an extra curly brace that will cause an error if compiled. These changes remove the rogue curly.

Contribution Guidelines

Copy link

CLAassistant commented Aug 6, 2025
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mzen228 thank you for your contribution! Please sign the CLA so that we can properly review your changes 🙏🏼

mzen228 reacted with thumbs up emoji

Copy link
Contributor Author

mzen228 commented Aug 9, 2025

@mzen228 thank you for your contribution! Please sign the CLA so that we can properly review your changes 🙏🏼

"Waiting for status to be reported — Contributor License Agreement is not signed yet."

I signed the CLA multiple times but I'm still getting this same message. above what to do now? FYI - my commit username is different from my github account. could this cause the CLA not to go through?

Copy link
Contributor

@mzen228 yes, that seems to be the issue - it doesn't seem to understand that you have a github account

image

@mzen228 mzen228 force-pushed the mzen228/nano-33-ble-sense-rev2-imu-accelerometer-fix branch from 56deca8 to 5eb0b54 Compare August 12, 2025 21:47
Signed-off-by: mzen228 <mzen228@proton.me>
@mzen228 mzen228 force-pushed the mzen228/nano-33-ble-sense-rev2-imu-accelerometer-fix branch from 5eb0b54 to 3636205 Compare August 12, 2025 23:42
Copy link
Contributor Author

mzen228 commented Aug 12, 2025

@mzen228 yes, that seems to be the issue - it doesn't seem to understand that you have a github account

I just pushed a rebased history with a username and email consistent with my github account. Now the CLA goes through without a problem!

jhansson-ard reacted with hooray emoji

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mzen228 thank you for your keen eyes! Approved and will merge your change now ⭐

mzen228 reacted with thumbs up emoji
@jhansson-ard jhansson-ard merged commit 537360e into arduino:main Aug 13, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhansson-ard jhansson-ard jhansson-ard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /