-
-
Notifications
You must be signed in to change notification settings - Fork 477
updated revision history #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated revision history #2541
Conversation
@pedromsousalima I added you as reviewer since you were reviewing my other PR, and @Hannes7eicher since the PR is relating to your PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a feedback
Please keep tables formated using tools like the VSCode markdown extension so we can keep also good format markdown file (little details, not critical but important in the long run)
https://marketplace.visualstudio.com/items?itemName=TakumiI.markdowntable
thanks :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are one of the bestes looking tables I've seen!!
What This PR Changes
Updated revision history for the fixes made in the #2500 PR.
@pedromsousalima, either let's wait for the #2536 and #2537 to be merged so that we can fix the conflicts that arise, or speak to @Hannes7eicher about merging this first and fixing his PRs.
Contribution Guidelines