-
-
Notifications
You must be signed in to change notification settings - Fork 476
[PXCT-969] add tiny-ml-kit step file #2530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PXCT-969] add tiny-ml-kit step file #2530
Conversation
@Hannes7eicher let's run the preview so that nothing breaks!
Preview Deployment
🚀 Preview this PR: https://6853e7215b22ba718cbfdd5d--docs-content.netlify.app
📍 Commit SHA: 8d151e7
I mean, through the direct URL it doesn't look good but then again I don't think people go there (also it didn't look good before either haha)
image
For me, I think it could be good enough!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hannes7eicher ! I agree with @jhansson-ard 's point in this case, since the hardware is in unlisted directory and so on. I'm not sure if the file should appear within the downloadable resources in this case (I think it should still appear, even if it is in unlisted directory), so I'd like to suggest by compressing the step file as we do and name as AKX00028-shield-step for example. Otherwise, based on the observation until now, lgtm
True @TaddyHC ! It might be the name of the file that makes it not show, please @Hannes7eicher try to rename the file and let's see
@jhansson-ard @TaddyHC I compressed the file and renamed it to AKX00028-shield-step.
I checked the preview and it now appears in the download section, so I will go ahead and merge this.
What This PR Changes
This PR adds the step file to the tiny ml kit
Contribution Guidelines