-
-
Notifications
You must be signed in to change notification settings - Fork 481
Style Guide Tutorials #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...de/arduino-creating-content-guide.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...de/arduino-creating-content-guide.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
...arduino-writing-style-guide.md
...de/arduino-creating-content-guide.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
Gatsby Cloud Build Report
docs-content
🎉 Your build was successful! See the Deploy preview here.
Build Details
🕐 Build time: 4m
karlsoderby
karlsoderby
approved these changes
May 12, 2022
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
content/learn/08.contributions/00.arduino-writing-style-guide/arduino-writing-style-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/03.arduino-creating-library-guide/arduino-creating-library-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/04.arduino-creating-content-guide/arduino-creating-content-guide.md
Outdated
Show resolved
Hide resolved
@karlsoderby please check the comments of commit suggestions :)
per1234
per1234
requested changes
May 12, 2022
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
content/learn/08.contributions/01.arduino-library-style-guide/arduino-library-style-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/03.arduino-creating-library-guide/arduino-creating-library-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/03.arduino-creating-library-guide/arduino-creating-library-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/04.arduino-creating-content-guide/arduino-creating-content-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/04.arduino-creating-content-guide/arduino-creating-content-guide.md
Outdated
Show resolved
Hide resolved
...t/learn/08.contributions/04.arduino-creating-content-guide/arduino-creating-content-guide.md
Outdated
Show resolved
Hide resolved
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
per1234
per1234
requested changes
May 12, 2022
...t/learn/08.contributions/03.arduino-creating-library-guide/arduino-creating-library-guide.md
Outdated
Show resolved
Hide resolved
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-content-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-writing-style-guide.md
per1234
per1234
requested changes
May 12, 2022
content/learn/08.contributions/00.arduino-writing-style-guide/arduino-writing-style-guide.md
Outdated
Show resolved
Hide resolved
...de/arduino-creating-content-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-writing-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-content-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
Hi @jhansson-ard. There are still some outstanding suggestions from my previous review. Please make a ruling on those.
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
...de/arduino-creating-library-guide.md Co-authored-by: per1234 <accounts@perglass.com>
@karlsoderby @per1234 please check again if you feel happy about the documents ⭐
...arduino-library-style-guide.md Co-authored-by: per1234 <accounts@perglass.com>
per1234
per1234
approved these changes
May 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'm very happy to see the restoration of this important document to the Arduino website.
@jhansson-ard
jhansson-ard
deleted the
sync/jhansson-ard/styleguide-tutorials
branch
May 20, 2022 12:14
Serjlee
pushed a commit
that referenced
this pull request
Dec 21, 2022
...ontent Nano 33 BLE Sense rev2 documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates some style guides on how to create content, including
What Needs To Be Reviewed
How To Give Feedback
Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏