-
-
Notifications
You must be signed in to change notification settings - Fork 483
[PXCT-161] Added rotation instructions for SqaureLine #2255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
karlsoderby
merged 5 commits into
main
from
benjamindannegard/squareline-tutorial-rotation-addition
Oct 29, 2024
Merged
[PXCT-161] Added rotation instructions for SqaureLine #2255
karlsoderby
merged 5 commits into
main
from
benjamindannegard/squareline-tutorial-rotation-addition
Oct 29, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Deployment
🚀 Preview this PR: https://6720a64e908ab6bea6e500bc--docs-content.netlify.app
📍 Commit SHA: e2abf7a
karlsoderby
karlsoderby
requested changes
Oct 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some small suggestions, otherwise looks good.
...nt/hardware/10.mega/shields/giga-display-shield/tutorials/10.square-line-tutorial/content.md
Outdated
Show resolved
Hide resolved
...nt/hardware/10.mega/shields/giga-display-shield/tutorials/10.square-line-tutorial/content.md
Outdated
Show resolved
Hide resolved
...nt/hardware/10.mega/shields/giga-display-shield/tutorials/10.square-line-tutorial/content.md
Outdated
Show resolved
Hide resolved
.../10.square-line-tutorial/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../10.square-line-tutorial/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
.../10.square-line-tutorial/content.md Co-authored-by: Karl Söderby <35461661+karlsoderby@users.noreply.github.com>
@karlsoderby
karlsoderby
changed the title
(削除) [GIGA Display Shield] Added rotation instructions for SqaureLine (削除ここまで)
(追記) [PXCT-161] Added rotation instructions for SqaureLine (追記ここまで)
Oct 28, 2024
karlsoderby
karlsoderby
approved these changes
Oct 28, 2024
@karlsoderby
karlsoderby
deleted the
benjamindannegard/squareline-tutorial-rotation-addition
branch
October 29, 2024 09:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines