Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[PC-1877] Pro 4G Module: AT Commands Post-Feedback Update #2250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcarolinares merged 19 commits into main from sync/taddy/pro-4g-module-AT-commands-update
Oct 29, 2024

Conversation

Copy link
Collaborator

@ArduinoBot ArduinoBot commented Oct 22, 2024

What This PR Changes

Updates the Portenta Mid Carrier user manual and AT commands with Pro 4G Module related documentation post feedback from Massimo Pennazio.

Contribution Guidelines

TaddyHC and others added 11 commits September 1, 2024 15:54
@ArduinoBot ArduinoBot added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team labels Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Preview Deployment

🚀 Preview this PR: https://67202ac07c30239d01f7384a--docs-content.netlify.app
📍 Commit SHA: 9f72a56

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done

@TaddyHC please check and ping me again

TaddyHC reacted with thumbs up emoji
Copy link
Contributor

TaddyHC commented Oct 23, 2024

@jcarolinares thanks for the feedback. I have made the updates per observation. Let me know if additional update is required please!

Copy link
Contributor

@TaddyHC I see you perform @MaxPayne86 feedback, that is great

please tell me when you think we are ready to publish

Copy link
Contributor

TaddyHC commented Oct 29, 2024

Thanks @MaxPayne86 and @jcarolinares for the important feedback! The updates have been made to address the feedback, and I hope they now present the information as it should. Please let me know your thoughts and if we should proceed with further review. Otherwise, I think we could move on to the next steps.

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be practical and and publish this, this is ready

cc @MaxPayne86 @TaddyHC @martab1994

TaddyHC reacted with thumbs up emoji
@jcarolinares jcarolinares merged commit 8b37a9a into main Oct 29, 2024
4 checks passed
@jcarolinares jcarolinares deleted the sync/taddy/pro-4g-module-AT-commands-update branch October 29, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxPayne86 MaxPayne86 MaxPayne86 left review comments

@TaddyHC TaddyHC TaddyHC left review comments

@jcarolinares jcarolinares jcarolinares approved these changes

@marqdevx marqdevx Awaiting requested review from marqdevx

Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /