Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix typo, it said sawtooth, it should say sine #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karlsoderby merged 1 commit into arduino:main from montoyamoraga:patch-1
Oct 21, 2024
Merged

fix typo, it said sawtooth, it should say sine #2241

karlsoderby merged 1 commit into arduino:main from montoyamoraga:patch-1
Oct 21, 2024

Conversation

Copy link
Contributor

@montoyamoraga montoyamoraga commented Oct 14, 2024

later in the tutorial the sawtooth wave is used.

What This PR Changes

  • it changes a mention of sawtooth wave, for sine wave, which is what it meant, it was a typo.

Contribution Guidelines

 

later in the tutorial the sawtooth wave is used.
Copy link

CLAassistant commented Oct 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jacobhylen since you're the original author, I need to ask you: I am not sure is a typo. what kind of curve shows the progenerated code?

Copy link
Contributor

Hello @g-castronovo
@montoyamoraga is correct, there was indeed a typo introduced at some point.
We should also change the comment in the code example here that also says sawtooth.
g-castronovo reacted with laugh emoji

@g-castronovo g-castronovo added fix/update A small fix or update community Bugs and fixes suggested by the community maker labels Oct 15, 2024
Copy link
Contributor

@karlsoderby karlsoderby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this typo @montoyamoraga , looks good to me.

@karlsoderby karlsoderby merged commit fa0d46f into arduino:main Oct 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlsoderby karlsoderby karlsoderby approved these changes

Assignees
No one assigned
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update maker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /