-
-
Notifications
You must be signed in to change notification settings - Fork 478
[PXCT-160] Appwizard tutorial #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview Deployment
🚀 Preview this PR: https://67e2d83a3336b46f5d96bb47--docs-content.netlify.app
📍 Commit SHA: b04d8f7
leonardocavagnis
leonardocavagnis
previously requested changes
Oct 16, 2024
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
...hields/giga-display-shield/tutorials/13.appwizard-guide/assets/appwizard-demo-folder-src.png
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
.../13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Leonardo Cavagnis <45899760+leonardocavagnis@users.noreply.github.com>
@BenjaminDannegard
BenjaminDannegard
changed the title
(削除) Benjamindannegard/appwizard tutorial (削除ここまで)
(追記) [PXCT-160] Appwizard tutorial (追記ここまで)
Mar 14, 2025
mcmchris
mcmchris
requested changes
Mar 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BenjaminDannegard I reviewed the tutorial and left some minor comments.
I would recommend for future tutorials to set your computer background to a solid color, (hex: D6EEF0) and to take screenshots directly on it so to avoid cropping images and giving consistency to the style.
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
content/hardware/10.mega/shields/giga-display-shield/tutorials/13.appwizard-guide/content.md
Show resolved
Hide resolved
.../13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
.../13.appwizard-guide/content.md Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
mcmchris
mcmchris
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Now
@jcarolinares
jcarolinares
requested review from
leonardocavagnis
and removed request for
karlsoderby and
leonardocavagnis
March 25, 2025 16:07
@jcarolinares
jcarolinares
dismissed
leonardocavagnis’s stale review
March 25, 2025 16:08
Changes and feedback were applied, dismissing review just to unblick the merge without bothering people
jcarolinares
jcarolinares
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the latest changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What This PR Changes
Contribution Guidelines