-
-
Notifications
You must be signed in to change notification settings - Fork 481
[MKC-1854] GIGA CAN / ADC fixes #2184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
the CANRX and CANTX pins are not attached to the ADC, and they were incorrectly documented, likely due to previous boards with form factor having these pins as A14/15
Preview Deployment
🚀 Preview this PR: https://66fa658020084c4566dad8e9--docs-content.netlify.app
📍 Commit SHA: d34a503
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the auto formatter got a little too excited and broke a few note banners :))
Although it also includes many fixes I would suggest we only change the pins and if we want to clean up articles we make a seperate PR.
What do you think?
@Hannes7eicher totally agree. Changes fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
two super small fixes I missed during the last review, otherwisee looks good!
content/hardware/10.mega/boards/giga-r1-wifi/tutorials/cheat-sheet/cheat-sheet.md
Outdated
Show resolved
Hide resolved
content/hardware/10.mega/boards/giga-r1-wifi/tutorials/cheat-sheet/cheat-sheet.md
Outdated
Show resolved
Hide resolved
...heet/cheat-sheet.md Co-authored-by: Hannes Siebeneicher <60609597+Hannes7eicher@users.noreply.github.com>
...heet/cheat-sheet.md Co-authored-by: Hannes Siebeneicher <60609597+Hannes7eicher@users.noreply.github.com>
The GIGA documentation had incorrectly labelled CANTX/CANRX pins (D93/D94) as ADC pins. These pins are not connected to the ADC.
Contribution Guidelines