Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update simple-audio-player.md #1992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
giuggiodk wants to merge 1 commit into arduino:main from giuggiodk:patch-1
Closed

Conversation

Copy link

@giuggiodk giuggiodk commented May 31, 2024
edited
Loading

Changed constant 4 with static SDCARD_SS_PIN

What This PR Changes

  • As SD.begin(4) fails using the constant, the solution is letting the library to decide itself the correct port number

Contribution Guidelines

Changed constant 4 with static SDCARD_SS_PIN
Copy link

CLAassistant commented May 31, 2024
edited
Loading

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

Hello @giuggiodk!

Please sign the CLA and we will take a look at your proposal. Thank you ⭐
cc @jacobhylen

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community labels May 31, 2024
Copy link
Contributor

Hello @giuggiodk 👋
The constant SDCARD_SS_PIN is not defined in the library, but is only in the samd core for the MKRZero variant.
As such, your proposal will unfortunately only compile for that specific board.

I still want to say thank you for taking the time to contribute.

Copy link
Author

giuggiodk commented Jul 31, 2024 via email

Hello Jacob Thanks for your message. As the constant 4 in the sample code (as I remember) I used for the specific MKR Zero is wrong, I thought it was a good idea to fix this for other users facing the same problem. Med venlig hilsen / Best regards Senior Software Engineer | +45 23 61 57 39 | AKQA | Staunings Plads 3, DK-1607 Copenhagen Fra: Jacob Hylén Sendt: 31. juli 2024 10:12 Til: arduino/docs-content ***@***.***> Cc: Angelo Brusati ***@***.***>; Mention ***@***.***> Emne: Re: [arduino/docs-content] Update simple-audio-player.md (PR #1992) [External Email] Hello @giuggiodk<https://urldefense.com/v3/__https:/github.com/giuggiodk__;!!AqRjRmr9!Hhd5gQYqasNy1wunU4iDqbt1ovTYg4DvKe5TG11GDeSrjnCX9XntOHRCFBb4vB9awNgyaJBblj0NcinTSubplccl2qY$> 👋 The constant SDCARD_SS_PIN is not defined in the library, but is only in the samd core for the MKRZero variant. As such, your proposal will unfortunately only compile for that specific board. I still want to say thank you for taking the time to contribute. — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/arduino/docs-content/pull/1992*issuecomment-2259924657__;Iw!!AqRjRmr9!Hhd5gQYqasNy1wunU4iDqbt1ovTYg4DvKe5TG11GDeSrjnCX9XntOHRCFBb4vB9awNgyaJBblj0NcinTSubpWLP1i0g$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AOPNXQTSOWNVUIDBYHF726DZPCL5LAVCNFSM6AAAAABISTL3EOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJZHEZDINRVG4__;!!AqRjRmr9!Hhd5gQYqasNy1wunU4iDqbt1ovTYg4DvKe5TG11GDeSrjnCX9XntOHRCFBb4vB9awNgyaJBblj0NcinTSubpW-ZpIDs$>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>> Privileged/Confidential Information may be contained in this message. If you are not the addressee indicated in this message (or responsible for delivery of the message to such person), you may not copy or deliver this message to anyone. In such case, you should destroy this message and kindly notify the sender by reply email. Please advise immediately if you or your employer does not consent to email for messages of this kind. Opinions, conclusions, and other information in this message that do not relate to the official business of AKQA, shall be understood as neither given nor endorsed by it. AKQA Denmark A/S (CVR 29203776)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /