Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

small typo #1970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
g-castronovo wants to merge 1 commit into main from g-castronovo/typo-tutorial-plc
Closed

small typo #1970

g-castronovo wants to merge 1 commit into main from g-castronovo/typo-tutorial-plc

Conversation

Copy link
Contributor

@g-castronovo g-castronovo commented May 22, 2024 •
edited
Loading

What This PR Changes

  • (Please explain here why you created the pull request and specify what it changes)

Contribution Guidelines

@g-castronovo g-castronovo added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels May 22, 2024
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @TaddyHC can you double check this change?

image

I want to make sure it is indeed a typo

Copy link
Contributor

TaddyHC commented May 24, 2024 •
edited
Loading

@jcarolinares I have just checked with the PLC IDE and it is typo which I made. I may have written as "IO Type" to separate and give better idea that it's about Input/Output Type but the PLC IDE is showing as IOType. So to follow consistency and so on, the correct expression for that case would be "IOType".

Also, if you guys would like, since we have this PR for the same content with major updates that is about to be published. So we could migrate the changes from present PR to the other one, have one PR that makes all the changes at once, and just to avoid version conflicts. What do you say?
g-castronovo reacted with thumbs up emoji

Copy link
Contributor Author

Sure, please go ahead and close this one then!
TaddyHC reacted with thumbs up emoji

@g-castronovo g-castronovo deleted the g-castronovo/typo-tutorial-plc branch July 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarolinares jcarolinares jcarolinares requested changes

@TaddyHC TaddyHC Awaiting requested review from TaddyHC

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /