-
-
Notifications
You must be signed in to change notification settings - Fork 478
Update ble-cheat-sheet.md #1810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed the RGB description and example code to reflect the fact that they are active-LOW and not active-HIGH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dkadish ☀️
Thanks for bringing this to our attention and for taking the time to fix it.
I see that we've made this error in the corresponding cheat sheets for the 3 other Nano 33 BLE boards as well (Nano 33 BLE, Nano 33 BLE Rev2, Nano 33 BLE Sense Rev2).
Can I ask you to apply these changes to those too? Then I'll go ahead and merge. :)
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the RGB description and example code to reflect the fact that they are active-LOW and not active-HIGH.
What This PR Changes
Contribution Guidelines