-
-
Notifications
You must be signed in to change notification settings - Fork 476
[PC-1602] Multiple changes on Opta #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs-content
🚀 Preview this PR: https://ceca6af9.docs-content.pages.dev
📍 Commit SHA: 26ca5ee
@jcarolinares
jcarolinares
requested review from
jhansson-ard
and removed request for
jhansson-ard
March 11, 2024 17:22
@jcarolinares
jcarolinares
changed the title
(削除) Multiple changes on Opta (削除ここまで)
(追記) [PC-1602] Multiple changes on Opta (追記ここまで)
Mar 11, 2024
TaddyHC
TaddyHC
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made some few suggestions, other than that, the changes LGTM
content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md
Outdated
Show resolved
Hide resolved
content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md
Outdated
Show resolved
Hide resolved
...nt/hardware/07.opta/opta-family/opta/tutorials/03.getting-started-with-modbus-rtu/content.md
Outdated
Show resolved
Hide resolved
...nt/hardware/07.opta/opta-family/opta/tutorials/03.getting-started-with-modbus-rtu/content.md
Outdated
Show resolved
Hide resolved
...t/hardware/07.opta/opta-family/opta/tutorials/15.home-automation-application-note/content.md
Outdated
Show resolved
Hide resolved
...t/hardware/07.opta/opta-family/opta/tutorials/15.home-automation-application-note/content.md
Outdated
Show resolved
Hide resolved
...olutions/solutions-and-kits/portenta-machine-control/tutorials/pmc-opta-temp-ctrl/content.md
Outdated
Show resolved
Hide resolved
TaddyHC
TaddyHC
reviewed
Mar 11, 2024
content/hardware/07.opta/opta-family/opta/tutorials/01.user-manual/content.md
Show resolved
Hide resolved
...-started-with-rs485/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...-started-with-rs485/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
...-started-with-modbus-rtu/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
Suggestion from Taddy's review added Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
Matteo-it
pushed a commit
that referenced
this pull request
Mar 12, 2024
* Multiple changes on Opta * Small but important fixes and improvements detected after Docs 2.0 web launch * Update content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com> * Update content/hardware/07.opta/opta-family/opta/tutorials/02.getting-started-with-rs485/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com> * Update content/hardware/07.opta/opta-family/opta/tutorials/03.getting-started-with-modbus-rtu/content.md Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com> * Apply suggestions from code review Suggestion from Taddy's review added Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com> --------- Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
@jhansson-ard
jhansson-ard
added
fix/update
A small fix or update
arduino
Bugs and fixes added by the Arduino Team
pro
labels
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Contribution Guidelines