Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

update for ethernet connectivity #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirkopac wants to merge 19 commits into arduino:main
base: main
Choose a base branch
Loading
from mirkopac:main
Open

update for ethernet connectivity #1767

mirkopac wants to merge 19 commits into arduino:main from mirkopac:main

Conversation

Copy link
Collaborator

@mirkopac mirkopac commented Feb 17, 2024

  • I've updated the sketch with two defines that allow for switching between Wi-Fi and Ethernet connection.
  • In the tutorial, I've added a brief description explaining the use of the defines for changing the connectivity.

Copy link
Contributor

@jhansson-ard jhansson-ard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mirkopac! I gave a small QA of the content of your fixes and your added tutorial. Please let me know if there is anything you don't understand or agree with 👍🏼

mirkopac and others added 12 commits February 19, 2024 10:53
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...ure-iot-tutorial-en/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...tt/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
...ure-iot-tutorial-en/content.md
Co-authored-by: Josefine Hansson <66409231+jhansson-ard@users.noreply.github.com>
Copy link
Collaborator Author

@jhansson-ard Hello, thank you I added the suggestions you offered.

jhansson-ard reacted with hooray emoji

@jcarolinares jcarolinares marked this pull request as draft February 27, 2024 09:56
@mirkopac mirkopac marked this pull request as ready for review March 2, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhansson-ard jhansson-ard jhansson-ard left review comments

@manchoz manchoz manchoz approved these changes

@akash73 akash73 Awaiting requested review from akash73

@jcarolinares jcarolinares Awaiting requested review from jcarolinares

@Fr4ng Fr4ng Awaiting requested review from Fr4ng

+1 more reviewer

@Puuuszzku Puuuszzku Puuuszzku approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /