-
-
Notifications
You must be signed in to change notification settings - Fork 477
Added forum slug to products missing them #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs-content
🚀 Preview this PR: https://cc5fcf06.docs-content.pages.dev
📍 Commit SHA: e20b1fb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhansson-ard looks good to me, but all URLs should contain a /c/ before the slug, otherwise its a 404. For example:
If that's intentional then I can go ahead and approve it.
Yes, this will be added in the pattern @Matteo-it is creating 🙌🏼
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, then all good @jhansson-ard
Uh oh!
There was an error while loading. Please reload this page.
What This PR Changes
To make the footer of the products contextual to the product page we are on, we can add the
forumCategorySlugto link to the relevant forum category.This PR updates all products under the
makerumbrella.Contribution Guidelines