Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add MkrIoTCarrier datasheet #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marqdevx merged 24 commits into main from marqdevx/MKRIoTCarrier/datasheet
May 20, 2022
Merged

Add MkrIoTCarrier datasheet #156

marqdevx merged 24 commits into main from marqdevx/MKRIoTCarrier/datasheet
May 20, 2022

Conversation

Copy link
Member

@marqdevx marqdevx commented Apr 8, 2022

What This PR Changes

  • Convert MKRIoTCarrier datasheet in MD

What Needs To Be Reviewed

  • Review formatting issues on the content

How To Give Feedback

Please leave your feedback as a Github review.
You can add comments to specific lines of content / code and ideally use Github's suggestion feature. 🙏

@marqdevx marqdevx added Datasheet fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team maker labels Apr 8, 2022
@marqdevx marqdevx requested a review from lunnea April 8, 2022 08:18
@marqdevx marqdevx self-assigned this Apr 8, 2022
@marqdevx marqdevx marked this pull request as ready for review April 8, 2022 13:17
@marqdevx marqdevx force-pushed the marqdevx/MKRIoTCarrier/datasheet branch from acc88d8 to 9a58bef Compare April 8, 2022 16:12
Copy link

CLAassistant commented Apr 8, 2022
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ marqdevx
✅ lunnea
✅ jhansson-ard
❌ SAUMITRAJAGDALE
You have signed the CLA already but the status is still pending? Let us recheck it.

@marqdevx marqdevx force-pushed the marqdevx/MKRIoTCarrier/datasheet branch from 9a58bef to 80fa188 Compare April 8, 2022 16:13
Copy link
Member Author

@sebromero im getting an issue and i could not fix it 🤔
image

@marqdevx marqdevx force-pushed the marqdevx/MKRIoTCarrier/datasheet branch from 6f98457 to 34fde31 Compare May 5, 2022 09:07
Copy link
Contributor

lunnea commented May 6, 2022

Before we merge, let @SAUMITRAJAGDALE add some changes from Alessandro in there!

Copy link
Member Author

marqdevx commented May 9, 2022

Before we merge, let @SAUMITRAJAGDALE add some changes from Alessandro in there!

Sure, all yours! 😄

Copy link
Contributor

@SAUMITRAJAGDALE please sign the CLA so that we can move forward with this PR ⭐

@marqdevx marqdevx force-pushed the marqdevx/MKRIoTCarrier/datasheet branch 2 times, most recently from 1e85bee to 81d78a6 Compare May 19, 2022 16:03
marqdevx and others added 21 commits May 19, 2022 18:10
@marqdevx marqdevx force-pushed the marqdevx/MKRIoTCarrier/datasheet branch from 81d78a6 to 62e3e08 Compare May 19, 2022 16:11
@marqdevx marqdevx merged commit 9a46969 into main May 20, 2022
@marqdevx marqdevx deleted the marqdevx/MKRIoTCarrier/datasheet branch May 20, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhansson-ard jhansson-ard jhansson-ard left review comments

+1 more reviewer

@lunnea lunnea lunnea approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
arduino Bugs and fixes added by the Arduino Team Datasheet fix/update A small fix or update maker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /