Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[AE-139] Correct I2C & SPI labelling in MKR Shield tech-specs.yml files #1262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebromero merged 2 commits into main from aliphys/I2C-SPI-MKR-Board-Fixes
Aug 23, 2023

Conversation

Copy link
Contributor

@aliphys aliphys commented Aug 10, 2023 •
edited
Loading

What This PR Changes

  • The Docs page ,specifically tech-specs.yml, is revised to ensure that
    • The protocol (SPI/I2C/other) is correct
    • The pins used for said protocol are documented (they are not all common)
    • CS pin (if applicable) is defined. (RGB Shield may not need a CS pin?)

Contribution Guidelines

@aliphys aliphys added documentation Improvements or additions to documentation arduino Bugs and fixes added by the Arduino Team labels Aug 10, 2023
Copy link

gatsby-cloud bot commented Aug 10, 2023

✅ docs-content deploy preview ready

@jacobhylen jacobhylen self-requested a review August 10, 2023 12:51
Copy link
Contributor

@sebromero sebromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me given that Ali thoroughly dug up this information. We are merging this. @jacobhylen if you find any issue, please report so we can open another PR.

@sebromero sebromero merged commit fbf1e7d into main Aug 23, 2023
@sebromero sebromero deleted the aliphys/I2C-SPI-MKR-Board-Fixes branch August 23, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebromero sebromero sebromero approved these changes

@jacobhylen jacobhylen Awaiting requested review from jacobhylen

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /