Correct pin numbers for Nano ESP32 LED #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jacobhylen merged 1 commit into arduino:main from per1234:fix-nano-esp32-led-pins

Jul 28, 2023

Merged

Correct pin numbers for Nano ESP32 LED #1233

jacobhylen merged 1 commit into arduino:main from per1234:fix-nano-esp32-led-pins

Jul 28, 2023

Conversation

per1234

Copy link

Contributor

@per1234 per1234 commented Jul 27, 2023

What This PR Changes

Arduino pin numbers are an arbitrary numerical identifier for the I/O pins on the microcontroller. They are mapped to the lower level identifier in the board's core variant. Generally, Arduino functions that take a pin number argument require that argument to be an Arduino pin number rather than some lower level identifier for the pin, and that is the case with the Arduino core functions for the Nano ESP32 board.

Previously, the documentation of the pins connected to the RGB LED on the Nano ESP32 board used the lower level ESP32 GPIO pin numbers in the digitalWrite calls in the code snippet. Since digitalWrite requires the use of an Arduino pin number, not a GPIO number, that code was wrong and did not control the RGB LED as claimed.

When correcting this error, I chose to use the human friendly constants rather than the bare integer literals (14, 15, 16).

Contribution Guidelines

I confirm that I have read the contribution guidelines and comply with them.

Additional Context

Originally reported at https://forum.arduino.cc/t/esp32u-code-problem-moisture-sensor-in-arduino-ide-ambient/1151663/3

@per1234


 Correct pin numbers for Nano ESP32 LED

286bfec

Arduino pin numbers are an arbitrary numerical identifier for the I/O pins on the microcontroller. They are mapped to
the lower level identifier in the board's core variant. Generally, Arduino functions that take a pin number argument
require that argument to be an Arduino pin number rather than some lower level identifier for the pin, and that is the
case with the Arduino core functions for the Nano ESP32 board.
Previously, the documentation of the pins connected to the RGB LED on the Nano ESP32 board used the lower level ESP32
GPIO pin numbers in the digitalWrite calls in the code snippet. Since digitalWrite requires the use of an Arduino pin
number, not a GPIO number, that code was wrong and did not control the RGB LED as claimed.
When correcting this error, I chose to use the human friendly constants rather than the bare integer literals (14, 15,
16).