Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

[MKC-1015]Fix range of PWM pins #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobhylen merged 5 commits into main from seaxwi-patch-2
Jul 12, 2023
Merged

[MKC-1015]Fix range of PWM pins #1145

jacobhylen merged 5 commits into main from seaxwi-patch-2
Jul 12, 2023

Conversation

Copy link
Contributor

@seaxwi seaxwi commented Jul 6, 2023 •
edited
Loading

What This PR Changes

  • Changes one instance of the range of recommended PWM pins from 2-12 to 2-13 in the cheat sheet.
  • Changes two instances of the range of recommended PWM pins from 2-12 to 2-13 in the data sheet.
  • Removes one empty line in the datasheet.

Contribution Guidelines

Copy link

gatsby-cloud bot commented Jul 6, 2023 •
edited
Loading

✅ docs-content deploy preview ready

@jhansson-ard jhansson-ard added Datasheet fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team labels Jul 10, 2023
Copy link
Contributor

Hej @seaxwi,
I don't see the datasheet changes your description implies that you've made, do you have forgotten local changes that should be pushed before a review? 😄
seaxwi reacted with thumbs up emoji

@jacobhylen jacobhylen changed the title (削除) Fix range of PWM pins (削除ここまで) (追記) [MKC-1015]Fix range of PWM pins (追記ここまで) Jul 10, 2023
Copy link
Contributor Author

seaxwi commented Jul 12, 2023

do you have forgotten local changes that should be pushed before a review

@jacobhylen Too right 👀

but I hadn't fixed the table, nice one 👍
jacobhylen reacted with rocket emoji

Copy link
Contributor

@BenjaminDannegard BenjaminDannegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobhylen jacobhylen merged commit dd7374a into main Jul 12, 2023
@jacobhylen jacobhylen deleted the seaxwi-patch-2 branch July 12, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminDannegard BenjaminDannegard BenjaminDannegard approved these changes

@karlsoderby karlsoderby Awaiting requested review from karlsoderby

@jacobhylen jacobhylen Awaiting requested review from jacobhylen

Assignees
No one assigned
Labels
arduino Bugs and fixes added by the Arduino Team Datasheet fix/update A small fix or update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /