-
-
Notifications
You must be signed in to change notification settings - Fork 476
[MKC-1011] [UNO R4 WiFi] VRTC & Off Pin tutorial #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ docs-content deploy preview ready
- Deploy preview
- Build logs · 2m build time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacobhylen great start, but I think we need to address the following:
- for the VRTC pin, I think we need to show an example sketch. RTC examples have a
startTime()initiated when the board starts, so this will probably overwrite the current time. If the purpose is to keep the time during power off, we need to show a method of obtaining it after re-launch. - circuit with batteries needs just a label on which pins we are connecting to.
- a circuit / render that shows precisely how to short GND with OFF (like this one).
- (optional) create a circuit with a power switch connected to OFF pin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just two small notes
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/vrtc-off/vrtc-off.md
Outdated
Show resolved
Hide resolved
content/hardware/02.hero/boards/uno-r4-wifi/tutorials/vrtc-off/vrtc-off.md
Outdated
Show resolved
Hide resolved
Co-authored-by: BenjaminDannegard <b.dannegard@arduino.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adressed but you're not here to re-review :(
Uh oh!
There was an error while loading. Please reload this page.
What This PR Changes
Contribution Guidelines