-
-
Notifications
You must be signed in to change notification settings - Fork 482
Fixed pinouts of Red and Green led of MKR 1010 wifi led example #1124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the pin colour assimnments in this tutorial were wrong (at least my MKR-WiFi-1010 doesn't match them). Green and Red seem to be swapped around. This code changes swaps the red and green pins. It also seems to make sense that the pin order matches the colour order in "RGB"
Update built-in-rgb.md for pin colour assignments
@jhansson-ard
jhansson-ard
added
the
community
Bugs and fixes suggested by the community
label
Jul 10, 2023
@ngolf Are you sure you're using a MKR WiFi 1010 board? If so, can you share the sketch that is producing the wrong colors?
The full sketch in the tutorial produces the expected behavior on my board (GREEN, RED, BLUE, OFF):
#include <WiFiNINA.h> #include <utility/wifi_drv.h> void setup() { WiFiDrv::pinMode(25, OUTPUT); //define green pin WiFiDrv::pinMode(26, OUTPUT); //define red pin WiFiDrv::pinMode(27, OUTPUT); //define blue pin } void loop() { WiFiDrv::analogWrite(25, 255); WiFiDrv::analogWrite(26, 0); WiFiDrv::analogWrite(27, 0); delay(1000); WiFiDrv::analogWrite(25, 0); WiFiDrv::analogWrite(26, 255); WiFiDrv::analogWrite(27, 0); delay(1000); WiFiDrv::analogWrite(25, 0); WiFiDrv::analogWrite(26, 0); WiFiDrv::analogWrite(27, 255); delay(1000); WiFiDrv::analogWrite(25, 0); WiFiDrv::analogWrite(26, 0); WiFiDrv::analogWrite(27, 0); delay(1000); }
Here's a reference to the unintuitive pin ordering by an Arduino firmware engineer: arduino-libraries/WiFiNINA#24 (comment).
I think this example could be improved by defining constants for the RGB pins and using them inside the loop() function.
Here's a reworked example that (1) declaring pin constants and (2) uses the conventional RGB order when referencing the pins:
#include <WiFiNINA.h> #include <utility/wifi_drv.h> const uint8_t LED_RED = 26; const uint8_t LED_GREEN = 25; const uint8_t LED_BLUE = 27; void setup() { WiFiDrv::pinMode(LED_RED, OUTPUT); //define red pin WiFiDrv::pinMode(LED_GREEN, OUTPUT); //define green pin WiFiDrv::pinMode(LED_BLUE, OUTPUT); //define blue pin } void loop() { WiFiDrv::analogWrite(LED_RED, 255); WiFiDrv::analogWrite(LED_GREEN, 0); WiFiDrv::analogWrite(LED_BLUE, 0); delay(1000); WiFiDrv::analogWrite(LED_RED, 0); WiFiDrv::analogWrite(LED_GREEN, 255); WiFiDrv::analogWrite(LED_BLUE, 0); delay(1000); WiFiDrv::analogWrite(LED_RED, 0); WiFiDrv::analogWrite(LED_GREEN, 0); WiFiDrv::analogWrite(LED_BLUE, 255); delay(1000); WiFiDrv::analogWrite(LED_RED, 0); WiFiDrv::analogWrite(LED_GREEN, 0); WiFiDrv::analogWrite(LED_BLUE, 0); delay(1000); }
1 task
Mine goes (Red / Green / Blue / Off / ...) with the built in example, and
(Green / Red / Blue / ...) with the reworked example you sent.
[image: image.png]
... On 2023年7月17日 at 08:40, seaxwi ***@***.***> wrote:
Here's a reworked example that (1) declaring pin constants and (2) uses
the conventional RGB order when referencing the pins:
#include <WiFiNINA.h>#include <utility/wifi_drv.h>
const uint8_t LED_RED = 26;const uint8_t LED_GREEN = 25;const uint8_t LED_BLUE = 27;
void setup() {
WiFiDrv::pinMode(LED_RED, OUTPUT); //define red pin
WiFiDrv::pinMode(LED_GREEN, OUTPUT); //define green pin
WiFiDrv::pinMode(LED_BLUE, OUTPUT); //define blue pin
}
void loop() {
WiFiDrv::analogWrite(LED_RED, 255);
WiFiDrv::analogWrite(LED_GREEN, 0);
WiFiDrv::analogWrite(LED_BLUE, 0);
delay(1000);
WiFiDrv::analogWrite(LED_RED, 0);
WiFiDrv::analogWrite(LED_GREEN, 255);
WiFiDrv::analogWrite(LED_BLUE, 0);
delay(1000);
WiFiDrv::analogWrite(LED_RED, 0);
WiFiDrv::analogWrite(LED_GREEN, 0);
WiFiDrv::analogWrite(LED_BLUE, 255);
delay(1000);
WiFiDrv::analogWrite(LED_RED, 0);
WiFiDrv::analogWrite(LED_GREEN, 0);
WiFiDrv::analogWrite(LED_BLUE, 0);
delay(1000);
}
—
Reply to this email directly, view it on GitHub
<#1124 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARVJZK7X3WHVJDHCYQ3GFRTXQTUAPANCNFSM6AAAAAAZZREFD4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
This swaps the pinouts of the Red and Green led. I believe the current example has them wrong (at least produces the wrong colours on my board). It also seems intuitive that the pinout order matches "R G B"
Contribution Guidelines