-
-
Notifications
You must be signed in to change notification settings - Fork 477
Mcmchris/edge control/smart irrigation system [PC-1259] #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jcarolinares
merged 122 commits into
main
from
mcmchris/edge-control/smart-irrigation-system
May 31, 2023
Merged
Mcmchris/edge control/smart irrigation system [PC-1259] #1070
jcarolinares
merged 122 commits into
main
from
mcmchris/edge-control/smart-irrigation-system
May 31, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ docs-content deploy preview ready
- Deploy preview
- Build logs · 3m build time
@mcmchris
mcmchris
deleted the
mcmchris/edge-control/smart-irrigation-system
branch
May 25, 2023 22:15
@mcmchris
mcmchris
restored the
mcmchris/edge-control/smart-irrigation-system
branch
May 25, 2023 22:15
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
jcarolinares
jcarolinares
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marta feedback reviewed and integrated
WIP in some small topics
Commit incoming
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
...5.pro-solutions/solutions-and-kits/edge-control/tutorials/smart-irrigation-system/content.md
Outdated
Show resolved
Hide resolved
jcarolinares
jcarolinares
approved these changes
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marta feedback reviewed and integrated
WIP in some small topics
Commit incoming
...rol/tutorials/smart-irrigation-system/content.md
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Remaining suggestions from Marta review accepted Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
...rol/tutorials/smart-irrigation-system/content.md Co-authored-by: martab1994 <93210545+martab1994@users.noreply.github.com>
Final grammar re-check ongoing
@jhansson-ard @martab1994 @TaddyHC and of course @mcmchris
I'm not going to say we should always do this kind of really extensive review (please don't) but I'm very proud of the process and help done by each of you to make this application note to shine more and more
So thank you!
Waiting internal feedback before publication
Go to Public
Merging
@jcarolinares
jcarolinares
deleted the
mcmchris/edge-control/smart-irrigation-system
branch
May 31, 2023 10:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What This PR Changes
Contribution Guidelines