-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add CI workflow to publish releases #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e746ea to
fca9786
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can remove also deploy.sh.
something is wrong with the version:
./arduinoOTA -version
1.3.0
I think we can remove also
deploy.sh.something is wrong with the version:
./arduinoOTA -version 1.3.0
It should be okay now.
fca9786 to
004880a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing this, and this is the only shell script, maybe we should remove also https://github.com/arduino/arduinoOTA/blob/ce63040f98ce22778810220179c0d9f234c6a440/.github/workflows/check-shell-task.yml
Version printing LGTM
004880a to
0bf49ac
Compare
The check markdown links is expected to fail, while the check markdown nope. @per1234 do you have an idea on why is failing?
The check markdown links is expected to fail, while the check markdown nope. @per1234 do you have an idea on why is failing?
@umbynos I think it's because there are some problems with the downloaded schema. The file-url is actually different from the file url used in the assets repo. I could fix it in a separate PR.
Oh right arduino/tooling-project-assets@888fcbf 🤦♂️
On every push of a tag named with a version format: - Build the project for all supported platforms. - Sign and notarize the macOS builds. - Create a GitHub release. - Builds and checksums are attached as release assets - A changelog generated from the commit history is added to the release description - If the tag has a pre-release version suffix, the GitHub release will be marked as a pre-release. - Upload the builds to Arduino's downloads server.
Introducing the use of a matrix, greatly improves time performances during the build making process, since each build task is performed simultaneously. To support this, a check has been added to avoid creating the same changelog more than once. The calculation of the checksums has also been modified. Previously, it was done three (3) times at different stages of the workflow. This is pointless, since the only checksums that matter are the ones calculated when the files are in their final form. For this reason, it is now only done once during the release creation.
0bf49ac to
e3c4d7e
Compare
Uh oh!
There was an error while loading. Please reload this page.
On every push of a tag named with a version format:
arduino/create-changelogfrom the commit history is added to the release descriptionAdditional information
The workflow has been modified to create parallel builds for each OS and calculate the relative checksums once, at the end of the process.
Test run: https://github.com/MatteoPologruto/arduinoOTA/actions/runs/3487993513
Test release: https://github.com/MatteoPologruto/arduinoOTA/releases/tag/99.99.99