Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add build timestamp to the --version output #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
per1234 merged 2 commits into main from per1234/version-timestamp
Nov 29, 2020
Merged

Conversation

Copy link
Contributor

@per1234 per1234 commented Nov 27, 2020

$ ./arduino-check --version
0.0.0+385b1e8 2020年11月27日T04:16:21+00:00
$ ./arduino-check --version --format json
{
 "version": "0.0.0+385b1e8",
 "buildTimestamp": "2020-11-27T04:16:21+00:00"
}

Copy link
Contributor

I checked this out and task built but I don't get the timestamp

{
 "version": "0.0.0+d5307a7",
 "buildTimestamp": ""
}

Copy link
Contributor Author

per1234 commented Nov 27, 2020

What do you get if you run this command?:

date --utc --iso-8601=second

Copy link
Contributor

I get an error for illegal option

date: illegal option -- -
usage: date [-jnRu] [-d dst] [-r seconds] [-t west] [-v[+|-]val[ymwdHMS]] ...
 [-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]

Copy link
Contributor Author

per1234 commented Nov 29, 2020

@ubidefeo please try it again now. I have changed the command to be compatible with macOS.

Copy link
Contributor

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timestamp showing up correctly
approved

per1234 reacted with thumbs up emoji
@per1234 per1234 merged commit aa2cfbf into main Nov 29, 2020
@per1234 per1234 deleted the per1234/version-timestamp branch November 29, 2020 23:40
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Sep 29, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

@rsora rsora Awaiting requested review from rsora

@silvanocerza silvanocerza Awaiting requested review from silvanocerza

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /