Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.6.0 in /ruledocsgen #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 27, 2024
edited
Loading

Bumps github.com/JohannesKaufmann/html-to-markdown from 1.4.0 to 1.6.0.

Release notes

Sourced from github.com/JohannesKaufmann/html-to-markdown's releases.

v1.6.0 - improved YoutubeEmbed

  • Add support for youtube-nocookie.com domain in YoutubeEmbed plugin

Thanks @​devAbreu for submitting a PR 🙏

v1.5.0 - start for lists

  1. Configure the numbering of a ordered list by using the start attribute.
<ol start="10">
 <li>10</li>
 <li>11</li>
 <li>12</li>
</ol>
  1. The YoutubeEmbed() and VimeoEmbed() plugins can now be used more easily. Please report any bugs that you encounter!

v1.4.2

What's Changed

Full Changelog: JohannesKaufmann/html-to-markdown@v1.4.1...v1.4.2

v1.4.1

No release notes provided.

Commits
  • aec0c4a update dependencies
  • e92a7a3 Add support for youtube-nocookie.com domain in YoutubeEmbed plugin (#99)
  • 2ec2259 Bump golang.org/x/net from 0.18.0 to 0.19.0 (#83)
  • 155a78b change vimeo & youtube embed plugins & README plugin list
  • fc090b2 feat: configure start of ol list
  • a5828fd Bump golang.org/x/net from 0.14.0 to 0.18.0 (#82)
  • fab894e Bump github.com/yuin/goldmark from 1.5.5 to 1.6.0 (#81)
  • bcbfd0d Bump golang.org/x/net from 0.9.0 to 0.14.0 (#74)
  • afdc7df Bump github.com/yuin/goldmark from 1.5.4 to 1.5.5 (#73)
  • 2273319 updated logo
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Copy link

codecov-commenter commented May 27, 2024
edited by codecov bot
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.97%. Comparing base (54f411c) to head (1c1701b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@
## main #735 +/- ##
=======================================
 Coverage 89.97% 89.97% 
=======================================
 Files 44 44 
 Lines 6772 6772 
=======================================
 Hits 6093 6093 
 Misses 555 555 
 Partials 124 124 
Flag Coverage Δ
unit 89.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.6.0 branch from 7e5a3d4 to ada6779 Compare June 5, 2024 06:07
@per1234 per1234 added the type: enhancement Proposed improvement label Jun 5, 2024
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes go build to fail for the github.com/arduino/arduino-lint/ruledocsgen module, as shown in the failure of the "Check Website" workflow:

https://github.com/arduino/arduino-lint/actions/runs/9379124006/job/25823527189?pr=735#step:7:73

Error: ../../../../go/pkg/mod/golang.org/x/net@v0.25.0/http2/transport.go:1109:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)

The solution will be to update the version of Go used by the project:

$ task go:rule-docs:build
task: [go:rule-docs:build] go build
# golang.org/x/net/http2
C:\Users\per\go\pkg\mod\golang.org\x\net@v0.25.0\http2\transport.go:1109:13: tc.NetConn undefined (type *tls.Conn has no field or method NetConn)
note: module requires Go 1.18
task: Failed to run task "go:rule-docs:build": exit status 2

Since resources are not available to take on that significant task at this time, this PR must be put on hold.

@per1234 per1234 added the status: on hold Do not proceed at this time label Jun 5, 2024
@per1234 per1234 removed the status: on hold Do not proceed at this time label Nov 25, 2024
Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot rebase

dependabot[bot] reacted with thumbs up emoji

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 25, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot recreate

dependabot[bot] reacted with thumbs up emoji

@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.6.0 branch from b8d0a8d to 91c8145 Compare November 25, 2024 05:50
Copy link
Contributor

per1234 commented Nov 25, 2024

@dependabot rebase

dependabot[bot] reacted with thumbs up emoji

Bumps [github.com/JohannesKaufmann/html-to-markdown](https://github.com/JohannesKaufmann/html-to-markdown) from 1.4.0 to 1.6.0.
- [Release notes](https://github.com/JohannesKaufmann/html-to-markdown/releases)
- [Commits](JohannesKaufmann/html-to-markdown@v1.4.0...v1.6.0)
---
updated-dependencies:
- dependency-name: github.com/JohannesKaufmann/html-to-markdown
 dependency-type: direct:production
 update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.6.0 branch from 91c8145 to af02ade Compare November 25, 2024 07:00
@per1234 per1234 merged commit 7e17337 into main Nov 25, 2024
49 checks passed
@per1234 per1234 deleted the dependabot/go_modules/ruledocsgen/github.com/JohannesKaufmann/html-to-markdown-1.6.0 branch November 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /