Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump github.com/stretchr/testify from 1.8.2 to 1.8.4 in /ruledocsgen #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 31, 2023
edited
Loading

Bumps github.com/stretchr/testify from 1.8.2 to 1.8.4.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Copy link

codecov-commenter commented May 31, 2023
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (da0bb57) 90.05% compared to head (c7e829d) 90.05%.

Additional details and impacted files
@@ Coverage Diff @@
## main #557 +/- ##
=======================================
 Coverage 90.05% 90.05% 
=======================================
 Files 44 44 
 Lines 6800 6800 
=======================================
 Hits 6124 6124 
 Misses 553 553 
 Partials 123 123 
Flag Coverage Δ
unit 90.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the previous bump PR, the minimum supported Go version of the package is now 1.19:

stretchr/testify@v1.8.2...v1.8.3#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R351

We are using 1.17 for this project. Even though there is no obvious breakage, I think it is a bad idea to update the package before we migrate this project to using a supported Go version so I will put this PR on hold.

@per1234 per1234 added type: enhancement Proposed improvement status: on hold Do not proceed at this time labels May 31, 2023
@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/stretchr/testify-1.8.4 branch 2 times, most recently from 8646307 to c7e829d Compare June 9, 2023 00:23
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.2 to 1.8.4.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.2...v1.8.4)
---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
 dependency-type: direct:production
 update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/ruledocsgen/github.com/stretchr/testify-1.8.4 branch from c7e829d to 433b68d Compare June 9, 2023 01:03
Copy link
Contributor

per1234 commented Dec 7, 2023

This bump will be done as part of #555. The normal procedure is to let Dependabot automatically close the PRs in this situation, but I think the backlog of PRs that will take a significant amount of work to merge have accumulated to the point where Dependabot is refraining from submitting PRs for trivial bumps.

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 7, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/ruledocsgen/github.com/stretchr/testify-1.8.4 branch December 7, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

Labels
status: on hold Do not proceed at this time topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /