-
-
Notifications
You must be signed in to change notification settings - Fork 12
Fix errors in package index project data unit tests for discoveryDependencies
#292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
per1234
merged 2 commits into
arduino:main
from
per1234:fix-discoverydependencies-tests
Nov 11, 2021
Merged
Fix errors in package index project data unit tests for discoveryDependencies
#292
per1234
merged 2 commits into
arduino:main
from
per1234:fix-discoverydependencies-tests
Nov 11, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assertions were added to the unit test tables for package index project data generation of pluggable discovery dependencies. However, the test table handling code was not updated to use those assertions, so they were ignored.
There were some typos in the test tables data for the discoveryDependencies components of the package index project data unit tests. Due to missing handling code for this part of the tables, the errors were not apparent. Once the handling code was added, they caused spurious test failures, which are fixed here.
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
type: imperfection
Perceived defect in any part of project
labels
Nov 11, 2021
Codecov Report
@@ Coverage Diff @@ ## main #292 +/- ## ======================================= Coverage 89.79% 89.79% ======================================= Files 44 44 Lines 6626 6626 ======================================= Hits 5950 5950 Misses 553 553 Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
umbynos
umbynos
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for linting a project, Arduino Lint collects information that may be needed by multiple rules, referred to as "project data".
For package index projects, this data includes the contents of the
packages[].platforms[].discoveryDependencies[]field, stored in a slice along with identifiers.At the time the code was added for collecting that project data, new assertions were added to the unit test tables to cover it, but the test table handling code was not updated, meaning the assertions were never tested.
This PR adds that missing test table handling code and also fixes some errors in the assertions that were revealed by testing them.