Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bump github.com/ory/jsonschema/v3 from 3.0.3 to 3.0.4 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2021
edited
Loading

Bumps github.com/ory/jsonschema/v3 from 3.0.3 to 3.0.4.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the topic: infrastructure Related to project infrastructure label Sep 24, 2021
Copy link

codecov-commenter commented Sep 24, 2021
edited
Loading

Codecov Report

Merging #279 (eb4998b) into main (66d5918) will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #279 +/- ##
==========================================
+ Coverage 89.79% 89.94% +0.14% 
==========================================
 Files 44 43 -1 
 Lines 6626 6464 -162 
==========================================
- Hits 5950 5814 -136 
+ Misses 553 536 -17 
+ Partials 123 114 -9 
Flag Coverage Δ
unit 89.94% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
ruledocsgen/main.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d5918...eb4998b. Read the comment docs.

@per1234 per1234 self-assigned this Nov 12, 2021
Copy link
Contributor

per1234 commented Nov 15, 2021

@dependabot recreate

dependabot[bot] reacted with thumbs up emoji

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

Copy link
Contributor

per1234 commented Nov 15, 2021

@dependabot rebase

dependabot[bot] reacted with thumbs up emoji

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@per1234 per1234 added the type: enhancement Proposed improvement label Nov 15, 2021
Copy link
Contributor

per1234 commented Nov 15, 2021

@dependabot rebase

dependabot[bot] reacted with thumbs up emoji

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 15, 2021

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

dependabot bot and others added 4 commits November 21, 2021 18:39
Bumps [github.com/ory/jsonschema/v3](https://github.com/ory/jsonschema) from 3.0.3 to 3.0.4.
- [Release notes](https://github.com/ory/jsonschema/releases)
- [Commits](ory/jsonschema@v3.0.3...v3.0.4)
---
updated-dependencies:
- dependency-name: github.com/ory/jsonschema/v3
 dependency-type: direct:production
 update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Since the `docsgen` and `ruledocsgen' modules have a dependency on the root module, they must be tidied after the change
to the root module dependencies.
...ndency
This is a transitive dependency of `github.com/ory/jsonschema/v3`.
`go mod tidy` fails after Dependabot bumps to `github.com/ory/jsonschema/v3@v3.0.4`:
```
go: downloading github.com/jandelgado/gcov2lcov v1.0.4
verifying github.com/jandelgado/gcov2lcov@v1.0.4: checksum mismatch
	downloaded: h1:ADwQPyNsxguqzznIbfQTENwY9FU88JdXEvpdHR9c48A=
	go.sum: h1:54+QJDjOQcRMLsC6aFXeYKQ+GEhN2DaYfKEtjDWnOrM=
SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.
For more information, see 'go help module-auth'.
```
I suspect that it was caused by the `github.com/jandelgado/gcov2lcov@v1.0.4` tag having been moved (similar to what
happened with `github.com/oleiade/reflections@v1.0.0`).
Since `github.com/jandelgado/gcov2lcov` is only a testing tool used by `github.com/ory/jsonschema/v3`, which imports it
as blank identifier as a hacky technique to use the Go module system for tool dependency management:
https://marcofranssen.nl/manage-go-tools-via-go-modules
For this reason, `github.com/jandelgado/gcov2lcov` is not actually a dependency of Arduino Lint and the version specified
here is irrelevant other than that v1.0.4 breaks Dependabot. So there is no possible impact from using v1.0.5 in its
place.
In the interest of keeping the `go.mod` file clean, this line should be removed once `github.com/ory/jsonschema/v3`
updates to a non-problematic version of its tool dependency.
@per1234 per1234 force-pushed the dependabot/go_modules/github.com/ory/jsonschema/v3-3.0.4 branch from fc9782d to 6ab2070 Compare November 22, 2021 02:42
@per1234 per1234 merged commit 9eeaf76 into main Nov 22, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/ory/jsonschema/v3-3.0.4 branch November 22, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /