Bump github.com/arduino/go-paths-helper from 1.4.0 to 1.6.1 #252

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the topic: infrastructure label

Aug 7, 2021

@dependabot @per1234


 Bump github.com/arduino/go-paths-helper from 1.4.0 to 1.6.1

0d75f45

Bumps [github.com/arduino/go-paths-helper](https://github.com/arduino/go-paths-helper) from 1.4.0 to 1.6.1.
- [Release notes](https://github.com/arduino/go-paths-helper/releases)
- [Commits](arduino/go-paths-helper@v1.4.0...v1.6.1)
---
updated-dependencies:
- dependency-name: github.com/arduino/go-paths-helper
 dependency-type: direct:production
 update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>

@per1234 per1234 force-pushed the dependabot/go_modules/github.com/arduino/go-paths-helper-1.6.1 branch from 0ae8d50 to 0d75f45 Compare

August 8, 2021 23:50

@codecov-commenter

Copy link

codecov-commenter commented Aug 9, 2021 •

edited

Loading

Codecov Report

Merging #252 (26b7c9d) into main (7374379) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@ Coverage Diff @@
## main #252 +/- ##
==========================================
- Coverage 89.85% 89.83% -0.03% 
==========================================
 Files 43 43 
 Lines 6320 6327 +7 
==========================================
+ Hits 5679 5684 +5 
- Misses 530 531 +1 
- Partials 111 112 +1

Flag	Coverage Δ
unit	`89.83% <85.71%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
internal/rule/rulefunction/library.go	`96.28% <85.71%> (-0.18%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7374379...26b7c9d. Read the comment docs.

@per1234


 Fix handling of missing lib examples folder

26b7c9d

The `rulefunction.MissingExamples` function was previously relying on the github.com/arduino/go-paths-helper IsDirCheck() method for two things
- Does examples path exist?
- Is examples path a folder?
The code made the unreasonable assumption that IsDirCheck() would return `false, nil` if the path did not exist, and an
error only if some unexpected failure occurred. That is not how IsDirCheck() is intended to work, as is clearly described
in its documentation. A bug fix to align the method's behavior with that stated in its docs caused it to correctly return
an error when the path did not exist, which caused an inappropriate panic from the `rulefunction.MissingExamples`
function when checking an examples folder that did not exist.
There is a dedicated method for checking path existence. By calling this method before `IsDirCheck()`, the code can
achieve its intended behavior of handling missing examples folders gracefully, only panicing in the event of some
unexpected failure that can't be handled without risking spurious linting results.