-
-
Notifications
You must be signed in to change notification settings - Fork 12
Finish sync of test infrastructure with "template" assets #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@per1234
per1234
changed the title
(削除) Finish sync of test infrastructure with " (削除ここまで)
(追記) Finish sync of test infrastructure with "template" assets (追記ここまで)
Aug 5, 2021
@per1234
per1234
added
topic: infrastructure
Related to project infrastructure
type: enhancement
Proposed improvement
labels
Aug 5, 2021
codecov-commenter
commented
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@ ## main #241 +/- ## ======================================= Coverage 89.85% 89.85% ======================================= Files 43 43 Lines 6320 6320 ======================================= Hits 5679 5679 Misses 530 530 Partials 111 111
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This script is now developed and maintained in a dedicated repository for such reusable project assets. This means that there is no need for its test code to be checked in to this repository. I did this by accident after having failed to follow the installation instructions carefully and am now correcting my mistake.
The `workflow_dispatch` event allows triggering the workflow via the GitHub web interface. This makes it easy to trigger an immediate workflow run after some relevant external change. The `repository_dispatch` event allows triggering workflows via the GitHub API. This might be useful for triggering an immediate check in multiple relevant repositories after an external change, or some automated process. Although we don't have any specific need for this event at the moment, the event has no impact on the workflow, so there is no reason against having it. It is the sort of thing that can end up being useful if it is already in consistently in place, but not worth setting up on demand, since the effort to set it up is greater than the effort to trigger all the workflows manually.
The official GitHub Actions documentation specifies the hosted macOS runner names use the `macos` prefix. Although the non-compliant case previously in use clearly does work, there is no guarantee it will continue to do so, so it's safest to follow the documentation exactly.
No functional change, and neither is necessarily superior, but this is how it is in the "template", and so it must be here as well.
Although the other works as well, this is the style specified in the official GitHub Actions reference and used in the "template" workflow.
There are two file extensions in common use for YAML files: `.yaml` and `.yml`. Although this project uses `.yml` exclusively for YAML files, standardized "template" workflows which might be applied to projects that have established the use of the other extension. It will be most flexible if it supports both.
umbynos
umbynos
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Some additional changes required for a full sync, which were non included in the first attempt (#227)