-
-
Notifications
You must be signed in to change notification settings - Fork 12
Provide schema validation results in package index project data #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
per1234
merged 1 commit into
arduino:main
from
per1234:package-index-schema-validation-results
Jun 15, 2021
Merged
Provide schema validation results in package index project data #193
per1234
merged 1 commit into
arduino:main
from
per1234:package-index-schema-validation-results
Jun 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the package index to be validated against its JSON schemas only once per project, with those results shared between all the schema-based rules.
@per1234
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
Jun 14, 2021
codecov-commenter
commented
Jun 14, 2021
Codecov Report
@@ Coverage Diff @@ ## main #193 +/- ## ========================================== - Coverage 84.25% 84.23% -0.02% ========================================== Files 43 43 Lines 3207 3210 +3 ========================================== + Hits 2702 2704 +2 - Misses 393 394 +1 Partials 112 112
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
umbynos
umbynos
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the package index to be validated against its JSON schemas only once per project, with those results shared
between all the schema-based rules.