Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add slice entries to projectdata for all package index components #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
per1234 merged 1 commit into arduino:main from per1234:resilient-component-data
Jun 14, 2021
Merged

Add slice entries to projectdata for all package index components #191

per1234 merged 1 commit into arduino:main from per1234:resilient-component-data
Jun 14, 2021

Conversation

Copy link
Contributor

@per1234 per1234 commented Jun 14, 2021

In order to provide rule results, it's necessary to identify even completely invalid package index components. The
previous behavior of skipping these components did not allow that.

In order to provide rule results, it's necessary to identify even completely invalid package index components. The
previous behavior of skipping these components did not allow that.
@per1234 per1234 added type: bug topic: code Related to content of the project itself labels Jun 14, 2021
Copy link

Codecov Report

Merging #191 (901fcd2) into main (f271d5f) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 84.03% 84.22% +0.19% 
==========================================
 Files 43 43 
 Lines 3201 3202 +1 
==========================================
+ Hits 2690 2697 +7 
+ Misses 396 393 -3 
+ Partials 115 112 -3 
Flag Coverage Δ
unit 84.22% <100.00%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/project/projectdata/packageindex.go 95.65% <100.00%> (+13.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f271d5f...901fcd2. Read the comment docs.

@per1234 per1234 merged commit f3c4d55 into arduino:main Jun 14, 2021
@per1234 per1234 deleted the resilient-component-data branch July 5, 2021 11:43
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 self-assigned this Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos Awaiting requested review from umbynos

1 more reviewer

@silvanocerza silvanocerza silvanocerza approved these changes

Reviewers whose approvals may not affect merge requirements
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /